Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch-exports): Include _inserted_at field in S3 batch exports #27019

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

rossgray
Copy link
Contributor

@rossgray rossgray commented Dec 18, 2024

Problem

We're not currently sending the _inserted_at field in our S3 events batch exports, which can be useful for knowing when the event was actually inserted into ClickHouse.

Changes

Update S3 events batch exports to include this field.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Should do

How did you test this code?

  • Updated existing tests
  • Tested locally that a batch export to MinIO included _inserted_at in the output file

@rossgray rossgray marked this pull request as ready for review December 18, 2024 18:07
@rossgray rossgray merged commit 5840967 into master Dec 19, 2024
97 checks passed
@rossgray rossgray deleted the ross/batch-exports-add-inserted-at branch December 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants