Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Impersonation suggestion #27018

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: Impersonation suggestion #27018

merged 2 commits into from
Dec 19, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

We had an early return for the new permissions that got in the way of the new style.

Changes

  • Changed it so we check no access via either old or new method and then do the check

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite enabled auto-merge (squash) December 19, 2024 08:10
@benjackwhite benjackwhite merged commit 877202d into master Dec 19, 2024
92 checks passed
@benjackwhite benjackwhite deleted the fix/impersonate-suggestion branch December 19, 2024 08:26
Copy link

sentry-io bot commented Dec 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: consuming input failed: query_wait_timeout /.* View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants