Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update supported platforms flags #27017

Merged
merged 4 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ function LinkedFlagSelector(): JSX.Element | null {
<LemonLabel className="text-base">
Enable recordings using feature flag {featureFlagLoading && <Spinner />}
</LemonLabel>
<SupportedPlatforms web={true} ios={true} android={true} reactNative={true} flutter={true} />
<p>Linking a flag means that recordings will only be collected for users who have the flag enabled.</p>
<div className="flex flex-row justify-start">
<FlagSelector
Expand Down Expand Up @@ -139,8 +140,6 @@ export function SessionRecordingIngestionSettings(): JSX.Element | null {
</Link>
</p>

<SupportedPlatforms web={true} />

{samplingControlFeatureEnabled && (
<>
<div className="flex flex-row justify-between">
Expand Down Expand Up @@ -243,6 +242,7 @@ export function SessionRecordingIngestionSettings(): JSX.Element | null {
}
/>
</div>
<SupportedPlatforms web={true} />
<p>
Use this setting to restrict the percentage of sessions that will be recorded. This is
useful if you want to reduce the amount of data you collect. 100% means all sessions will be
Expand All @@ -264,6 +264,7 @@ export function SessionRecordingIngestionSettings(): JSX.Element | null {
value={currentTeam?.session_recording_minimum_duration_milliseconds}
/>
</div>
<SupportedPlatforms web={true} />
<p>
Setting a minimum session duration will ensure that only sessions that last longer than that
value are collected. This helps you avoid collecting sessions that are too short to be
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function SupportedPlatforms(props: {
flutter?: boolean | { note?: ReactNode }
}): JSX.Element {
return (
<div className="text-xs inline-flex flex-row bg-bg-3000 rounded items-center border overflow-hidden mb-2">
<div className="text-xs inline-flex flex-row bg-bg-3000 rounded items-center border overflow-hidden mb-2 w-fit">
<span className="px-1 py-0.5 font-semibold">Supported platforms:</span>
<LemonDivider vertical className="h-full" />
<SupportedPlatform
Expand Down Expand Up @@ -103,7 +103,7 @@ function LogCaptureSettings(): JSX.Element {
return (
<div>
<h3>Log capture</h3>
<SupportedPlatforms android={true} ios={true} flutter={true} web={true} reactNative={true} />
<SupportedPlatforms android={true} ios={false} flutter={false} web={true} reactNative={true} />
<p>
This setting controls if browser console logs will be captured as a part of recordings. The console logs
will be shown in the recording player to help you debug any issues.
Expand Down Expand Up @@ -208,7 +208,13 @@ export function NetworkCaptureSettings(): JSX.Element {

return (
<>
<SupportedPlatforms android={true} ios={true} flutter={false} web={true} reactNative={false} />
<SupportedPlatforms
android={true}
ios={true}
flutter={false}
web={true}
reactNative={{ note: <>RN network capture is only supported on iOS</> }}
/>
<p>
This setting controls if performance and network information will be captured alongside recordings. The
network requests and timings will be shown in the recording player to help you debug any issues.
Expand Down
Loading