feat(web-analytics): Support diff on Web Goals dashboard #26999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not computing diff for the web goals section of our dashboard. This wasn't detected earlier because we don't have any actions on our local setup - we should change that. Besides adding diff, we're also now properly formatting it in the UI, it was previously using the old formatting, therefore percentages were not accurate.
robbie-c
approved these changes
Dec 18, 2024
| @@ -25,93 +34,153 @@ class WebGoalsQueryRunner(WebAnalyticsQueryRunner): | |||
| cached_response: CachedWebGoalsQueryResponse | |||
|
|
|||
| def to_query(self) -> ast.SelectQuery | ast.SelectSetQuery: | |||
| with self.timings.measure("actions"): | |||
There was a problem hiding this comment.
In case you're wondering why we time so much:
We used to use a python version of ANTLR to parse HogQL, and it was really slow, to the point where it would often take just as long as the actual query on clickhouse!
Since then, we've switched to the C++ version, which is way faster, but a lot of these timing statements come from the times before that (or from copying code from that era).
Hopefully, loading the actions from Postgres should be fast!
There was a problem hiding this comment.
Aah, I thought they were just useful in general, so that's why I added that hahah
I will keep it in mind :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were not computing diff for the web goals section of our dashboard. This wasn't detected earlier because we don't have any actions on our local setup - we should change that.
Changes
Besides adding diff, we're also now properly formatting it in the UI, it was previously using the old formatting, therefore percentages were not accurate.
After doesn't have data, but you can see it's properly formatted
Does this work well for both Cloud and self-hosted?
Yep
How did you test this code?
Manual UI test + updated automated tests