Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product-analytics): most used property values for the agent #26985

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Dec 17, 2024

Problem

To scrape info about a business, we need to get the most frequent origins or app bundle IDs. There isn't a query that can do that.

Changes

Modify the EventTaxonomyQuery to support an optional property filtering. If properties are used, we'll remove the descending ordering by the timestamp and output the five most frequent values.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Unit tests.

@skoob13 skoob13 requested a review from Twixes December 17, 2024 17:51
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@skoob13 skoob13 merged commit 3e95fdc into master Dec 18, 2024
101 checks passed
@skoob13 skoob13 deleted the feat/ai-most-used-property-values branch December 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants