Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use False inside or Clickhouse query #26984

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Member Author

@rafaeelaudibert rafaeelaudibert Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we'll need to change any of our tests, let's see if CI will complain

Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ def _current_period_expression(self, field="start_timestamp"):
)

def _previous_period_expression(self, field="start_timestamp"):
# NOTE: Returning `ast.Constant(value=None)` is painfully slow, make sure we return a boolean
if not self.query_compare_to_date_range:
return ast.Constant(value=None)
return ast.Constant(value=False)

return ast.Call(
name="and",
Expand Down
Loading