test: Remove disabled/skipped E2E tests #26980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't believe skipped/disabled tests have any actual value, and they simply add noise to our PR reviews. I'm proposing we remove them all. If there's anything here that needs to actually be fixed, then it should become a GH issue.
|
Does anyone disagree with my take? :) |
rafaeelaudibert
requested review from
robbie-c,
a team,
pauldambra,
Twixes,
benjackwhite and
zlwaterfield
pauldambra
approved these changes
Dec 18, 2024
pauldambra
reviewed
Dec 18, 2024
| * | ||
| * Needs https://github.com/PostHog/posthog/issues/8250 before can query on timestamp | ||
| */ | ||
| it.skip('can filter after a date and can filter before it', () => { |
There was a problem hiding this comment.
that sounds super fixable but 🤷
Terrible idea, I know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe skipped/disabled tests have any actual value, and they add noise to our PR reviews. I'm proposing we remove them all. If there's anything here that needs to be fixed, then it should become a GH issue.