chore(flags): stop checking clickhouse for feature flag status endpoint #26951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
reviewed
Dec 16, 2024
dmarticus
approved these changes
Dec 16, 2024
Co-authored-by: Dylan Martin <[email protected]>
…m/PostHog/posthog into flags/remove-ch-query-flag-status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're seeing some clickhouse errors on this endpoint lately: https://posthog.sentry.io/issues/6149399926 + https://posthog.sentry.io/issues/6149406182
We do not actually use the result of this clickhouse query in the UI today, so there's no use letting in cause the endpoint to error out, and no real use in running the query for now either. This PR simply skips that step, leaving the query code in though for later use.
Changes
No functional changes to product today
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested stale flag checks still work as intended