Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): Auto-join persons table to dw table #26947

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Dec 16, 2024

See #26332
See https://posthog.slack.com/archives/C07PXH2GTGV/p1734361832990139?thread_ts=1733936406.339719&cid=C07PXH2GTGV

Changes

Auto-joins the person_distinct_ids and persons tables onto the data warehouse table when the data warehouse table is optimized for experiments. This enables the "Filter out internal and test users" functionality to work seamlessly.

Previously #26911

How did you test this code?

Tests should pass.

@danielbachhuber danielbachhuber changed the title WIP feat(experiments): Auto-join persons table to dw table Dec 17, 2024
@danielbachhuber danielbachhuber requested a review from a team December 17, 2024 23:28
@danielbachhuber danielbachhuber marked this pull request as ready for review December 17, 2024 23:28
@danielbachhuber danielbachhuber merged commit 3169809 into master Dec 18, 2024
99 of 100 checks passed
@danielbachhuber danielbachhuber deleted the experiments/support-person-distinct-ids branch December 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants