fix: fewer version warnings #26942
Merged
fix: fewer version warnings #26942
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
ioannisj
approved these changes
Dec 17, 2024
| @@ -188,18 +189,14 @@ export const versionCheckerLogic = kea<versionCheckerLogicType>([ | |||
| } | |||
|
|
|||
| let level: 'warning' | 'info' | 'error' | undefined | |||
| if (diff.kind === 'major' || numVersionsBehind >= 20) { | |||
| if (diff.kind === 'major') { | |||
| level = 'info' // it is desirable to be on the latest major version, but not critical | |||
There was a problem hiding this comment.
I may be missing some context here, but isn't being a major version behind critical?
There was a problem hiding this comment.
i think not until we start deprecating the old versions... i guess we're very unlikely to increment a major version in web sdk... although more likely in mobile. easy to change if we figure out a better setup :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few users have reported that the version warning banner is tiring not helpful, because we release so much
and anecdotally, folk are opening tickets in support despite seeing that banner, so let's show it to people less often