fix(cdp): batch exports only in destinations list #26940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjackwhite
approved these changes
Dec 16, 2024
| actions.loadPlugins() | ||
| actions.loadPluginConfigs() | ||
| actions.loadBatchExports() | ||
| if (props.types.includes('destination')) { |
There was a problem hiding this comment.
Probably should be filtered out as well but if this works thats good enough i guess...
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Batch exports were showing up under "site apps"
Changes
Now they will only show up for destinations.
How did you test this code?
Locally the export I had made disappeared from the list.