fix: add fixed heights for date picker and table header (month and buttons) #26932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleithp
added
design
|
Size Change: +40 B (0%) Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated32 snapshot changes in total. 0 added, 32 modified, 0 deleted:
Triggered by this commit. |
adamleithp
changed the title
daibhin
approved these changes
Dec 16, 2024
| @@ -7,6 +7,8 @@ | |||
| // Tricky: needs to match the equivalent height button from LemonButton.scss | |||
| --lemon-calendar-time-button-height: 2.3125rem; | |||
|
|
|||
| height: 305px; | |||
There was a problem hiding this comment.
Might be worth making this a variable or at least saying what this value is composed of
There was a problem hiding this comment.
Added! good call on the self documentation.
…Hog/posthog into adam/date-picker-fixed-height-19964
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Date picker jumping around is poor UX
Changes
Add fixed height to date
.LemonCalendarso when clicking through the months the height is set to the highest the element will be to reduce jankyness in the height when passing through months.Before:
Fixed height for whole table
Fixed height for month table header
After:
Fixed height for whole table
Fixed height for month table header
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested the fix in major browsers, and shrunk the screen down to see if it works