Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Decide via RemoteConfig rollout #26925

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

Problem

When we are ready to go with the RemoteConfig, safest way of testing (bizarely) is to go via decide as this is 1-1 compatible.

Changes

  • Remove fallback options and only use decide

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite changed the title Fix p tests feat: Decide via RemoteConfig rollout Dec 16, 2024
Copy link

sentry-io bot commented Dec 16, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/api/decide.py

Function Unhandled Issue
get_decide ValueError: Invalid IPv6 URL /decide/[#].*
Event Count: 4
get_decide TypeError: 'str' object is not a mapping /decide/...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Base automatically changed from fix/recording-domains to master December 16, 2024 13:19
@benjackwhite benjackwhite changed the title feat: Decide via RemoteConfig rollout wip: Decide via RemoteConfig rollout Dec 17, 2024
benjackwhite and others added 3 commits December 17, 2024 09:54
…stHog/posthog into feat/rollout-remote-config-via-decide
# Conflicts:
#	posthog/hogql/transforms/test/__snapshots__/test_in_cohort.ambr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant