feat: query-ify the matching_events API #26916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Dec 14, 2024
| @@ -69,7 +69,6 @@ export function RecordingRow({ recording }: RecordingRowProps): JSX.Element { | |||
| onClick={() => { | |||
| openSessionPlayer({ | |||
| id: recording.id, | |||
| matching_events: recording.matching_events, | |||
There was a problem hiding this comment.
these are never present here, so we can delete this
pauldambra
commented
Dec 14, 2024
| const response = await api.recordings.getMatchingEvents(params) | ||
| } | ||
| if (values.listAPIAsQuery) { | ||
| params.as_query = true |
There was a problem hiding this comment.
switch to the new query code (or not)
pauldambra
commented
Dec 14, 2024
| raise exceptions.ValidationError( | ||
| "Must specify exactly one session_id", | ||
| ) | ||
| if use_query_type: |
There was a problem hiding this comment.
a little duplication is ok since we're going to delete one branch pretty soon
pauldambra
commented
Dec 14, 2024
| ] | ||
|
|
||
| response = self.client.get( | ||
| f"/api/projects/{self.team.id}/session_recordings/matching_events?{'&'.join(query_params)}&as_query=true" |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
robbie-c
approved these changes
Dec 16, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API still depends on the old shaped filters which I want to delete
So, shift it to not using those... (behind a flag)