Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noticed a flappy test #26894

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: noticed a flappy test #26894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion posthog/rbac/test/test_user_access_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,9 @@ def test_filters_project_queryset_based_on_acs_always_allows_org_admin(self):
filtered_teams = list(
self.user_access_control.filter_queryset_by_access_level(Team.objects.all(), include_all_if_admin=True)
)
assert filtered_teams == [self.team, team2, team3]
assert sorted(filtered_teams, key=lambda team: team.id) == sorted(
[self.team, team2, team3], key=lambda team: team.id
)

def test_organization_access_control(self):
# A team isn't always available like for organization level routing
Expand Down
Loading