Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): Prevent long selectors from overflowing #26888

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Dec 13, 2024

Changes

Prevents long selectors in the web toolbar from overflowing.

Before After
CleanShot 2024-12-12 at 16 42 59@2x CleanShot 2024-12-12 at 16 42 26@2x

Reported in https://posthoghelp.zendesk.com/agent/tickets/21963

How did you test this code?

Visual review.

@danielbachhuber danielbachhuber requested a review from a team December 13, 2024 00:45
Copy link
Contributor

Size Change: +16 B (0%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +16 B (0%)

compressed-size-action

Copy link
Contributor

@jurajmajerik jurajmajerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbachhuber danielbachhuber merged commit 875fd4b into master Dec 13, 2024
99 checks passed
@danielbachhuber danielbachhuber deleted the experiments/fix-overflow branch December 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants