Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flags): hide flag status indicator when status in inactive #26883

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

havenbarnes
Copy link
Contributor

Problem

When a Posthog user only uses /decide to check flag values and never an explicit singular flag check in an SDK, they would have no $feature_flag_called events despite using the flag value, which is how the inactive state is determined.

Changes

  • Hide flag status indicator when status is "inactive"

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Loaded previously-inactive flag UI to make sure it is hidden

Copy link
Contributor

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@havenbarnes havenbarnes merged commit ac24c1f into master Dec 12, 2024
97 checks passed
@havenbarnes havenbarnes deleted the flags/hide-inactive-status branch December 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants