feat: snapshot library CH column migration #26867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Dec 12, 2024
There was a problem hiding this comment.
🤷 nothing to do with this PR 🤷
fuziontech
reviewed
Dec 12, 2024
posthog/clickhouse/migrations/0095_add_snapshot_library_tracking.py
Outdated
Show resolved
Hide resolved
…ng.py Co-authored-by: James Greenhill <[email protected]>
|
Looks good, just that one comment. I've added the columns to the cluster with no issues! 🚢 IT! |
fuziontech
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting just the clickhouse migration out of #26747
This adds a new column to session_replay_events that will help us track usage as we add mobile replay billing
The SDKS send lib_version as well, but in the short to medium term we don't need this on the table, so I'm not going to add it now
I've tested this by