Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: first time for user with filters #26858

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: first time for user with filters #26858

merged 2 commits into from
Dec 12, 2024

Conversation

aspicer
Copy link
Contributor

@aspicer aspicer commented Dec 12, 2024

Problem

First time for user with filters was not filtering on the event itself, just on the filters

Changes

AND the event in

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added a unit test for the situation

@aspicer aspicer requested a review from a team December 12, 2024 02:26
thmsobrmlr
thmsobrmlr approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aspicer aspicer merged commit a7194a4 into master Dec 12, 2024
89 checks passed
@aspicer aspicer deleted the aspicer/filter_bug_fix branch December 12, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspicer @thmsobrmlr