Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no need to error when seeking past end of recording #26853

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: no need to error when seeking past end of recording #26853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions frontend/src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ export const sessionRecordingPlayerLogic = kea<sessionRecordingPlayerLogicType>(
}
if (sessionPlayerData.segments.length) {
for (const segment of sessionPlayerData.segments) {
if (segment.startTimestamp <= timestamp && segment.endTimestamp >= timestamp) {
if (segment.startTimestamp <= timestamp && timestamp <= segment.endTimestamp) {
return segment
}
}
Expand Down Expand Up @@ -864,22 +864,28 @@ export const sessionRecordingPlayerLogic = kea<sessionRecordingPlayerLogicType>(
actions.setCurrentSegment(segment)
}

if (!values.snapshotsLoaded) {
// We haven't started properly loading, or we're still polling so nothing to do
} else if (!values.isRealtimePolling && !values.snapshotsLoading && segment?.kind === 'buffer') {
// If not currently loading anything,
// and part of the recording hasn't loaded, set error state
values.player?.replayer?.pause()
actions.endBuffer()
console.error("Error: Player tried to seek to a position that hasn't loaded yet")
actions.setErrorPlayerState(true)
}

// If next time is greater than last buffered time, set to buffering
else if (segment?.kind === 'buffer') {
values.player?.replayer?.pause()
actions.startBuffer()
actions.setErrorPlayerState(false)
const isStillLoading = values.isRealtimePolling || values.snapshotsLoading
const isPastEnd = values.sessionPlayerData.end && timestamp > values.sessionPlayerData.end.valueOf()
if (isStillLoading) {
values.player?.replayer?.pause()
actions.startBuffer()
actions.setErrorPlayerState(false)
} else {
if (isPastEnd) {
actions.setEndReached(true)
} else {
// If not currently loading anything,
// not past the end of the recording,
// and part of the recording hasn't loaded,
// set error state
values.player?.replayer?.pause()
actions.endBuffer()
console.error("Error: Player tried to seek to a position that hasn't loaded yet")
actions.setErrorPlayerState(true)
}
}
}

// If not forced to play and if last playing state was pause, pause
Expand Down
Loading