Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): Add a WHERE statement to ASOF LEFT JOIN #26848

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(experiments): Add a WHERE statement to ASOF LEFT JOIN #26848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions posthog/warehouse/models/join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ def _join_function_for_experiments(
}.items()
],
select_from=ast.JoinExpr(table=ast.Field(chain=["events"])),
where=ast.CompareOperation(
op=ast.CompareOperationOp.Eq,
left=ast.Field(chain=["event"]),
right=ast.Constant(value="$feature_flag_called"),
),
),
# ASOF JOIN finds the most recent matching event that occurred at or before each data warehouse timestamp.
#
Expand Down
Loading