feat(alerts): check alerts earlier #26843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
approved these changes
Dec 11, 2024
thmsobrmlr
reviewed
Dec 11, 2024
posthog/tasks/alerts/utils.py
Outdated
| tomorrow_local = datetime.now(team_timezone) + relativedelta(days=1) | ||
|
|
||
| # set time to 1:00 AM | ||
| one_am_local = tomorrow_local.replace(hour=1, minute=0, second=0, microsecond=0) |
There was a problem hiding this comment.
We could use the minute from the creation date also for daily/weekly/monthly alerts, to further spread out the load (probably won't make too much of a difference).
In the same spirit we could do daily at 1am, weekly at 2am, etc. All of this might be confusing when we communicate the calculation times to users, so we might just keep it as it is as well.
There was a problem hiding this comment.
That's a great point. Since we're calculating these during off peak times for the users, might be worth spreading this out :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Daily/weekly/monthly alert checks were spread out randomly during the day/month to spread out the load on our side. But also meant that we weren't checking/alerting as early as we could.
Changes
Check the daily alerts at start of day, weekly and monthly at start of week/month. But we also account for the team's timezone so these alert checks should still be spread out by the timezone
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Added tests