Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): fix text card overlapping edit button (closes #26285, #26413) #26828

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

thmsobrmlr
Copy link
Contributor

Problem

The content of text cards can overlap the edit button. This is most notable for text cards with code blocks.

See also:

Changes

  • Adds a padding on the right side of the content, so that it doesn't overlap the button.

Before
Screenshot 2024-12-11 at 12 45 20

After
Screenshot 2024-12-11 at 12 43 20

How did you test this code?

👀

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr requested a review from a team December 11, 2024 12:42
@thmsobrmlr thmsobrmlr merged commit 050513d into master Dec 11, 2024
96 checks passed
@thmsobrmlr thmsobrmlr deleted the fix-26285-text-card-overlapping-button branch December 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants