feat(experiments): Always allow refreshing experiment results #26811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
andehen
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Looks good. I guess the reasoning behind it was that experiment results shouldn't change after it's stopped or archived, as the data should not change. But our calculations can change (bug fixing f.ex), and now with the data warehouse integration, data that the customer can control (let's say the refresh a table there to update data that is being joined in), it makes sense to always allow refresh.
|
Requested a second opinion from @jurajmajerik, just in case there's some reason this shouldn't be there. |
jurajmajerik
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Restores the UI to refresh experiment results when an experiment is completed or archived:
It looks like the conditional was originally added in 8ff6f2a (#21686) but it's not super clear why.
I wanted to refresh the results for https://posthoghelp.zendesk.com/agent/tickets/21723, but it's a completed experiment so I don't have the UI for it.
How did you test this code?
I verified that each of the buttons worked as expected when an experiment is completed.