Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hog transformations (UI) #26798

Merged
merged 21 commits into from
Dec 16, 2024
Merged

feat: Hog transformations (UI) #26798

merged 21 commits into from
Dec 16, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 10, 2024

Problem

My hobby project whilst I'm waiting for CI things.

Plan is to get the UI etc. all hooked up so that we could play with this internally.

Changes

  • Adds the UI for transformations heavily feature flagged

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

benjackwhite and others added 6 commits December 10, 2024 17:04
# Conflicts:
#	frontend/src/scenes/pipeline/hogfunctions/filters/HogFunctionFilters.tsx
#	posthog/api/hog_function.py
#	posthog/cdp/templates/__init__.py
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Size Change: +42 B (0%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB +42 B (0%)

compressed-size-action

@benjackwhite benjackwhite changed the title feat: Hog transformations feat: Hog transformations (UI) Dec 13, 2024
@benjackwhite benjackwhite marked this pull request as ready for review December 13, 2024 13:25
@benjackwhite benjackwhite merged commit 9408d1c into master Dec 16, 2024
96 checks passed
@benjackwhite benjackwhite deleted the feat/hog-transformations branch December 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants