Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggregate exception events for overrides #26762

Merged
merged 20 commits into from
Dec 10, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Dec 9, 2024

Problem

We are migrating to using the overrides table for fingerprint merging

Changes

Implementing the overrides pattern described in https://github.com/PostHog/product-internal/blob/main/requests-for-comments/2024-10-08-error-tracking-issue-overrides.md#fetching-events

Based on the changes made in #21059 to support lazy table joins

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added tests back

@daibhin daibhin merged commit d102474 into master Dec 10, 2024
89 checks passed
@daibhin daibhin deleted the dn-feat/aggregating-exception-overrides branch December 10, 2024 15:38
Copy link

sentry-io bot commented Dec 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ UnboundLocalError: cannot access local variable 'span' where it is not associated with a value posthog.tasks.tasks.process_query_task View Issue
  • ‼️ UnboundLocalError: cannot access local variable 'span' where it is not associated with a value posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants