Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding capture for when event verification is toggled #26740

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

surbhi-posthog
Copy link
Contributor

Problem

We weren't capturing the event when use toggles event verification

A few more captures still needed to be added which I will follow up on:

  • SSO enforcement which is turned on after verifying a domain.
  • Project permissions - so if someone toggles project private/public
  • Ingestion taxonomy - if someone marks events as verified
  • White label branding - surveys and sharing dashboards

Changes

I've added backend changes to verify that the event gets logs

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Cloud: Yes

How did you test this code?

Tested locally and verified that the event came through in activity monitor. I think adding tests are a bit unnecessary here, but can do if needed.

image

@surbhi-posthog surbhi-posthog requested a review from a team December 6, 2024 21:56
@surbhi-posthog surbhi-posthog marked this pull request as ready for review December 6, 2024 21:56
@surbhi-posthog surbhi-posthog merged commit 8c9fb01 into master Dec 9, 2024
89 checks passed
@surbhi-posthog surbhi-posthog deleted the event_capture branch December 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants