feat(cdp): add missing oauth scopes warning #26738
Conversation
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
| }), | ||
| }} | ||
| > | ||
| Required scopes are missing: [{missingScopes.join(', ')}]. Note that some features may not be available |
There was a problem hiding this comment.
Feels like the hubspot part could be omitted and instead just left out as it makes this needlessly unique to hubspot when it could for sure work (and should) for all the other oauth things
There was a problem hiding this comment.
Yes, it could work for multiple oauth integrations, but the way to get the authorized scopes is really different as it seems:
- Slack - In the
x-oauth-scopesheaders from the token info URL. - Hubspot - Under the
scopeskey from the token info URL. - Google - Under the
scopekey from the token info URL OR under thescopekey from the token URL.
Will look into it.
There was a problem hiding this comment.
I've pushed some changes to generalize the logic. We'll grab authorized tokens from multiple possible locations:
370d97a (#26738)
I've also added requiredScopes to our existing templates with oauth integrations.
…hen getting an access token
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
MarconLP
changed the title
|
Yes - Verified that it works with all of our current integrations: salesforce, google, slack, & hubspot. |
…-top-to-bottom-edit--dark.png
Problem
https://posthoghelp.zendesk.com/agent/tickets/21531
Changes
requiredScopesfield to the oauth inputDoes this work well for both Cloud and self-hosted?
How did you test this code?