feat: Update component with new design system: LemonBanner #26726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anner styles to use 3030 semantic variables
pauldambra
approved these changes
Dec 6, 2024
pauldambra
changed the title
adamleithp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 3030 semantic variables in LemonBanner, Also adding the variables for this design system.
Problem
text/background/border/ etc is ambiguous, ideally the engieeer doesn't have to think about these themes, or darkmodeProblem described in more detail here: https://github.com/PostHog/product-internal/issues/687
Changes
Old:
New
Old
New:
More on new color design system here: https://www.figma.com/design/rQ5SvWb4P2AGt7o9KbKV21/Posthog-3030?node-id=79-12331&node-type=frame&t=q0VjMeVe4xZF0j0G-0
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Opened all instances i could find of the component, in light/dark