fix(settings): Fix back button and side panel when opening settings #26702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Quoting @rafaeelaudibert:
Quoting @annikaschmid:
Both apply only behind the
environments
feature flag.Changes
The cause of redundant history items was an awkward interaction between
urlToAction
andactionToUrl
insettingsSceneLogic
:urlToAction
calledselectLevel
/selectSection
with the redirected path, which caused those actions'actionToUrl
handlers to create new history items.Now
selectLevel
/selectSection
replace the current history item, and we no longer use them in the settings scene.The settings scene uses URLs instead, which is overall better ergonomics (e.g. you can now use "Open in new tab" in settings).
The redirect only applied in
settingsSceneLogic
, but we also now have analogous logic for side panel settings in the lower-levelsettingsLogic
.How did you test this code?
Clicked around in this case.