perf: Only drop columns and indexes associated with materialized columns if they exist #26664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DROP
actions still create mutations, even if those actions don't have anything to drop and these inconsequential mutations are slow to execute. This makes retrying a task unnecessarily slow if after a partial failure or timeout occurs.Reducing the number of materialized columns we manage is part of #26651.
Changes
Only drop columns and indexes if they actually exist, otherwise skip these steps.
Since these tasks are run via
ClickhouseCluster
on specific hosts/shards, this should be resilient to partial failures on a per-shard basis.Does this work well for both Cloud and self-hosted?
N/A, Cloud only
How did you test this code?
Added tests to ensure optimization works as expected, otherwise covered by existing lifecycle tests.