-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experiments and flags product intents #26661
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Looks fine from the experiments side of things. Out of curiosity, what does "activated" mean to us? |
For experiments, it's launching an experiment (ie adding a start_date). We can change this later if we want. |
Oh, I understand how "activated" is measured but what does it actually mean? That the user has "used" the feature? |
Oh! For your reading pleasure: https://posthog.com/product-engineers/activation-metrics Also https://posthog.com/handbook/growth/growth-engineering/product-intents |
Great blog post :) |
My name's on it but it was really 99% lior and ian! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! Just the one nit
.exclude(name__istartswith="Feature Flag for Experiment") | ||
.exclude(name__istartswith="Targeting flag for survey") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this feels like it could be a bit brittle, if we changed the prefix for these types of flags. Think it would be too expensive to exclude via a reverse lookup on experiments / surveys? I'm not sure how often this runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's probably a better solution. It shouldn't be too expensive because the discrete number of flags / experiments per project is low (ie in the hundreds, not hundreds of thousands).
I'll do that.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
If someone is already a posthog user, we want to know if they show intent to start using feature flags and experiments, so they can be part of the activation funnel.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Should
How did you test this code?
Added tests