Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experiments and flags product intents #26661

Merged
merged 11 commits into from
Dec 7, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

If someone is already a posthog user, we want to know if they show intent to start using feature flags and experiments, so they can be part of the activation funnel.

Changes

  • Adds product intents for these two things
  • Handles the case where someone is an existing already-activated user so those people don't enter our funnel

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Should

How did you test this code?

Added tests

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@danielbachhuber
Copy link
Contributor

Looks fine from the experiments side of things.

Out of curiosity, what does "activated" mean to us?

@raquelmsmith
Copy link
Member Author

Out of curiosity, what does "activated" mean to us?

For experiments, it's launching an experiment (ie adding a start_date). We can change this later if we want.

@danielbachhuber
Copy link
Contributor

For experiments, it's launching an experiment (ie adding a start_date). We can change this later if we want.

Oh, I understand how "activated" is measured but what does it actually mean? That the user has "used" the feature?

@raquelmsmith
Copy link
Member Author

Oh! For your reading pleasure: https://posthog.com/product-engineers/activation-metrics

Also https://posthog.com/handbook/growth/growth-engineering/product-intents

@danielbachhuber
Copy link
Contributor

Oh! For your reading pleasure: posthog.com/product-engineers/activation-metrics

Great blog post :)

@raquelmsmith
Copy link
Member Author

Great blog post :)

My name's on it but it was really 99% lior and ian!

Copy link
Contributor

@havenbarnes havenbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Just the one nit

Comment on lines 94 to 95
.exclude(name__istartswith="Feature Flag for Experiment")
.exclude(name__istartswith="Targeting flag for survey")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this feels like it could be a bit brittle, if we changed the prefix for these types of flags. Think it would be too expensive to exclude via a reverse lookup on experiments / surveys? I'm not sure how often this runs.

Copy link
Member Author

@raquelmsmith raquelmsmith Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's probably a better solution. It shouldn't be too expensive because the discrete number of flags / experiments per project is low (ie in the hundreds, not hundreds of thousands).

I'll do that.

@raquelmsmith raquelmsmith enabled auto-merge (squash) December 7, 2024 00:08
@raquelmsmith raquelmsmith merged commit 5764870 into master Dec 7, 2024
96 checks passed
@raquelmsmith raquelmsmith deleted the feat/add-product-intents branch December 7, 2024 06:38
Copy link

sentry-io bot commented Dec 9, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.models.product_intent.product_intent.ca... View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.models.product_intent.product_intent.ca... View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.models.product_intent.product_intent.ca... View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.models.product_intent.product_intent.ca... View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout posthog.models.product_intent.product_intent.ca... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants