fix: Do not merge heartbeat ranges #26653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
commented
Dec 4, 2024
Comment on lines
+56
to
+71
| NON_RETRYABLE_ERROR_TYPES = [ | ||
| # Raised on errors that are related to database operation. | ||
| # For example: unexpected disconnect, database or other object not found. | ||
| "OperationalError", | ||
| # The schema name provided is invalid (usually because it doesn't exist). | ||
| "InvalidSchemaName", | ||
| # Missing permissions to, e.g., insert into table. | ||
| "InsufficientPrivilege", | ||
| # A column, usually properties, exceeds the limit for a VARCHAR field, | ||
| # usually the max of 65535 bytes | ||
| "StringDataRightTruncation", | ||
| # Raised by our PostgreSQL client when failing to connect after several attempts. | ||
| "PostgreSQLConnectionError", | ||
| # Column missing in Redshift, likely the schema was altered. | ||
| "UndefinedColumn", | ||
| ] |
There was a problem hiding this comment.
Err, didn't intend to get this out yet, working on SPMC for redshift. But anyways, won't hurt to merge now.
rossgray
approved these changes
Dec 5, 2024
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Merging heartbeat ranges in batch exports has currently two problems:
Until we update the queue to keep track of a record batch index that we can use to merge ranges together, let's just not merge.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?