Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-warehouse): Allow key pair auth for snowflake sources #26652

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Gilbert09
Copy link
Member

Changes

  • Support keypair auth for snowflake sources

Does this work well for both Cloud and self-hosted?

Yep

How did you test this code?

Local testing

@Gilbert09 Gilbert09 requested a review from a team December 4, 2024 18:08
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gilbert09 Gilbert09 enabled auto-merge (squash) December 6, 2024 12:35
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Gilbert09 Gilbert09 merged commit 58f0a33 into master Dec 6, 2024
96 checks passed
@Gilbert09 Gilbert09 deleted the tom/snowflake-keypair branch December 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants