Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product-assistant): filter out reasoning messages #26648

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Dec 4, 2024

Problem

Reasoning messages are only useful in UI. A thread now reaches its maximum limit after a fourth message.

Changes

  • Bump max message count.
  • Filter out reasoning messages when a thread finishes generating.

Does this work well for both Cloud and self-hosted?

No

How did you test this code?

Manual testing

@skoob13 skoob13 requested a review from Twixes December 4, 2024 16:09
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@skoob13 skoob13 merged commit 8d3e2bd into master Dec 6, 2024
97 checks passed
@skoob13 skoob13 deleted the fix/filter-out-reasoning-messages branch December 6, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants