chore: type updates for rbac #26647
Merged
chore: type updates for rbac #26647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlwaterfield
changed the title
8 tasks
|
Size Change: +189 B (+0.02%) Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
benjackwhite
approved these changes
Dec 5, 2024
| @@ -49,15 +49,18 @@ export const inviteLogic = kea<inviteLogicType>([ | |||
| { | |||
| inviteTeamMembers: async () => { | |||
| if (!values.canSubmit) { | |||
| return { invites: [] } | |||
There was a problem hiding this comment.
Amazing this didn't previously fail type validation 🤔
There was a problem hiding this comment.
We have a lot of weird type things with kea that seem to pass for now reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pulling some of the types changes from https://github.com/PostHog/posthog/pull/20864/files?file-filters%5B%5D=.ts&file-filters%5B%5D=.tsx&show-viewed-files=true into their own PR for simplicity of reviewing keeping PRs small.
Not functionality changes. Just need to make sure lint and type checks pass.
Check issue for more info on the progress.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact.
How did you test this code?
Manually + CI