feat: toolbar event debugger #26561
Merged
feat: toolbar event debugger #26561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Nov 30, 2024
| ) | ||
| } | ||
|
|
||
| ToolbarMenu.Footer = function ToolbarMenufooter({ children, className }: ToolbarMenuProps): JSX.Element { | ||
| return <div className={clsx('flex flex-row items-center p-2 border-t gap-2', className)}>{children}</div> | ||
| ToolbarMenu.Footer = function ToolbarMenufooter({ children, className, noPadding }: ToolbarMenuProps): JSX.Element { |
There was a problem hiding this comment.
i only needed no padding in this component i think
but felt weird for it to not be an option throughout
|
Size Change: -52.5 kB (-4.53%) ✅ Total Size: 1.11 MB
|
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
ioannisj
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
I like the no padding footer in the example screenshot, but I feel that we may need it here where there's a CTA button?
📸 UI snapshots have been updated16 snapshot changes in total. 0 added, 16 modified, 0 deleted:
Triggered by this commit. |
zlwaterfield
pushed a commit
that referenced
this pull request
Dec 2, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some feeback from a user that this confused them
It's pretty raw
Let's make it slightly less so