Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: some activity item row improvements in replay #26555

Merged
merged 12 commits into from
Dec 2, 2024
Merged

feat: some activity item row improvements in replay #26555

merged 12 commits into from
Dec 2, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 29, 2024 •
edited
Loading

towards #26098

  • fixes a duration display
  • adds an image tab when viewing an autocapture event in activity page and replay
  • move flags to their own tab in event details
  • add an elements tab for autocapture events in replay inspector
Screenshot 2024-11-29 at 20 39 52 Screenshot 2024-11-29 at 20 39 34 Screenshot 2024-11-29 at 20 49 01

2024-11-29 20 17 42

@pauldambra pauldambra requested review from daibhin and a team November 29, 2024 20:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Size Change: -259 B (-0.02%)

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.11 MB -259 B (-0.02%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

17 snapshot changes in total. 0 added, 17 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra enabled auto-merge (squash) December 2, 2024 09:36
daibhin
daibhin approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking!

frontend/src/scenes/session-recordings/apm/playerInspector/ItemPerformanceEvent.tsx Show resolved Hide resolved
frontend/src/lib/utils/event-property-utls.tsx Show resolved Hide resolved
frontend/src/lib/taxonomy.tsx Outdated Show resolved Hide resolved
@pauldambra pauldambra disabled auto-merge December 2, 2024 10:07
@pauldambra pauldambra enabled auto-merge (squash) December 2, 2024 12:16
@pauldambra pauldambra merged commit fa08767 into master Dec 2, 2024
96 checks passed
@pauldambra pauldambra deleted the feat/activity-item-improvements branch December 2, 2024 13:57
zlwaterfield pushed a commit that referenced this pull request Dec 2, 2024
@pauldambra @github-actions @zlwaterfield
feat: some activity item row improvements in replay (#26555)
57b0818 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldambra @posthog-bot @daibhin