chore(environments): Calculate cohorts for each environment #26554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
environment-cohorts
branch
from
6ad03fc to
7aa6034
Compare
Twixes
force-pushed
the
environment-cohorts
branch
from
f427eef to
a34bd33
Compare
Twixes
force-pushed
the
environment-cohorts
branch
from
c624701 to
9ad70ee
Compare
posthog/api/cohort.py
Outdated
| @@ -240,22 +238,31 @@ def update(self, cohort: Cohort, validated_data: dict, *args: Any, **kwargs: Any | |||
|
|
|||
| is_deletion_change = deleted_state is not None and cohort.deleted != deleted_state | |||
| if is_deletion_change: | |||
| relevant_team_ids = ( | |||
| Team.objects.order_by("id").filter(project_id=cohort.team.project_id).values_list("id", flat=True) | |||
There was a problem hiding this comment.
curious why we need order_by("id") here
There was a problem hiding this comment.
Good question, I don't remember 😄 It's definitely superfluous here, removed
There was a problem hiding this comment.
Looks ok to me but will let Sandy comment on how this fits in with his rewrite + maybe @dmarticus as feature flags uses behavioural cohorts
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Appendix A of the environments implementation plan.
Changes
recalculate_cohortpeople()andclear_stale_cohortpeople()now insert and clear cohort people for every team the cohort is available in, instead of just the one the cohort was created in.How did you test this code?
Added a test case to
test_cohort.py. Definitely let me know how to improve test coverage!