fix(environments): Update API calls for using currentProjectId
#26550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Twixes
force-pushed
the
fix-project-api-paths
branch
from
bab4fc8 to
391cc05
Compare
rafaeelaudibert
approved these changes
Dec 2, 2024
daibhin
approved these changes
Dec 2, 2024
| @@ -891,7 +899,7 @@ export const hogFunctionConfigurationLogic = kea<hogFunctionConfigurationLogicTy | |||
| } | |||
| const { id, name, type } = values.hogFunction | |||
| await deleteWithUndo({ | |||
| endpoint: `projects/${teamLogic.values.currentTeamId}/hog_functions`, | |||
| endpoint: `projects/${values.currentProjectId}/hog_functions`, | |||
There was a problem hiding this comment.
Could probably get away with values.currentProject.id here and remove the need for the currentProjectId value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current users of environments (i.e. us) have been seeing this:
This was because we were calling endpoints like this:
projects/${currentTeamId}/...rather than like so:projects/${currentProjectId}/...Changes
Updated all the relevant API calls to the
projects/${currentProjectId}/...form (I think I haven't missed any, though it's possible).