refactor(taxonomy): Add project field to taxonomy models #26521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
taxonomy-project
branch
from
bd3b0ed to
4e3bf0b
Compare
Twixes
commented
Nov 28, 2024
plugin-server/src/types.ts
Outdated
There was a problem hiding this comment.
Only types need to be updated in the plugin server, since these records are SELECTed with *
Twixes
force-pushed
the
taxonomy-project
branch
from
c32a39a to
b54cb8e
Compare
Twixes
force-pushed
the
taxonomy-project
branch
from
bbb6a2d to
7f9a755
Compare
Twixes
force-pushed
the
taxonomy-project
branch
from
7f9a755 to
38a1242
Compare
oliverb123
reviewed
Dec 4, 2024
rust/property-defs-rs/src/types.rs
Outdated
| @@ -84,6 +84,7 @@ impl GroupType { | |||
| #[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord)] | |||
| pub struct PropertyDefinition { | |||
| pub team_id: i32, | |||
| pub project_id: i32, | |||
There was a problem hiding this comment.
bigint's are i64's, I think? 8 bytes wide.
| @@ -9,6 +9,7 @@ CREATE TABLE IF NOT EXISTS posthog_eventdefinition ( | |||
| volume_30_day INTEGER, | |||
| query_usage_30_day INTEGER, | |||
| team_id INTEGER NOT NULL, | |||
| project_id INTEGER NULL, | |||
There was a problem hiding this comment.
Better to keep these in sync and make them a bigint
Twixes
force-pushed
the
taxonomy-project
branch
from
3804d6a to
6cca91d
Compare
pauldambra
added a commit
that referenced
this pull request
Dec 6, 2024
)" This reverts commit caaf6a0.
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Step 9 of the environments implementation plan. (Same as #25600, just for taxonomy models.)
Changes
Added nullable field
projectto theEventDefinition,PropertyDefinition, andEventPropertymodels. We now insert it in ingestion.Backfill for existing event definitions, property definitions, and event properties will come in a separate PR.
How did you test this code?
All existing tests should continue to pass.