Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(experiments): Always show button to remove a transform #26485

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

danielbachhuber
Copy link
Contributor

Changes

Always shows the button to remove a transform, instead of only showing it when there are two or more transforms.

If my first transform is incorrect and I want to remove it, it's not obvious that I need to add a second one in order to do so.

I think this logic was originally added in response to #25190 (comment)

Before

CleanShot 2024-11-27 at 12 30 54@2x

After

CleanShot 2024-11-27 at 12 29 51@2x

How did you test this code?

I removed the transform and verified I could save the experiment as expected.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Size Change: -35 B (0%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB -35 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@jurajmajerik jurajmajerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@jurajmajerik jurajmajerik merged commit 6c79437 into master Nov 29, 2024
96 checks passed
@jurajmajerik jurajmajerik deleted the experiments/always-allow-delete branch November 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants