Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-warehouse): Support for Experiment-optimized JOINs #26446

Merged
merged 23 commits into from
Dec 2, 2024

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Nov 26, 2024

See #26332

Changes

Adds a new "Optimize for Experiments" field to data warehouse joins when "events" is selected as the joining table:

CleanShot 2024-11-30 at 04 54 11@2x

The user must also select a source timestamp key:

CleanShot 2024-11-30 at 04 54 55@2x

Data warehouse trends experiment continues to display the expected data:

CleanShot 2024-11-30 at 04 56 06@2x

Clicking "Explore results" generates an insight that renders as expected:

CleanShot 2024-11-30 at 04 56 21@2x

How did you test this code?

  • Created a new data warehouse join and verified:
    • The "Optimize for Experiments" field doesn't display when the joining table is not "events".
    • The "Optimize for Experiments" field displays as expected when the joining table is "events".
    • Selecting a "Source Timestamp Key" sets "Optimize for Experiments" as selected.
    • Unchecking "Optimize for Experiments" clears the "Source Timestamp Key" field.
    • Values are loaded as expected when editing a data warehouse join.
  • Verified my existing data warehouse experiment results displayed as expected.
  • Clicked on "Explore results" and verified the insight rendered data as expected.
  • All tests passed.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@danielbachhuber danielbachhuber force-pushed the experiments/optimized-dw-configuration branch from c835d19 to d088921 Compare November 30, 2024 09:45
@danielbachhuber danielbachhuber changed the title feat(data-warehouse): Experiment-optimized JOINs feat(data-warehouse): Support for Experiment-optimized JOINs Nov 30, 2024
Copy link
Member

@Gilbert09 Gilbert09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a heads up that this join functionality will eventually be replaced by "data modeling" in data warehouse in likely ~3 months time - but we'll make sure to chat to you guys before we do anything there (cc @EDsCODE)

@danielbachhuber danielbachhuber merged commit dd9f827 into master Dec 2, 2024
96 checks passed
@danielbachhuber danielbachhuber deleted the experiments/optimized-dw-configuration branch December 2, 2024 14:37
Copy link

sentry-io bot commented Dec 2, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ResolutionError: Can not access property "properties" on field "event" of type: StringDatabaseField posthog.tasks.tasks.process_query_task View Issue
  • ‼️ QueryError: Unable to resolve field: properties posthog.tasks.tasks.process_query_task View Issue
  • ‼️ QueryError: Unable to resolve field: events posthog.tasks.tasks.process_query_task View Issue
  • ‼️ ResolutionError: Invalid field access with empty chain posthog.tasks.tasks.process_query_task View Issue
  • ‼️ AttributeError: 'NoneType' object has no attribute 'resolve_constant_type' posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

zlwaterfield pushed a commit that referenced this pull request Dec 2, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants