-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-warehouse): Support for Experiment-optimized JOINs #26446
feat(data-warehouse): Support for Experiment-optimized JOINs #26446
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
c835d19
to
d088921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a heads up that this join functionality will eventually be replaced by "data modeling" in data warehouse in likely ~3 months time - but we'll make sure to chat to you guys before we do anything there (cc @EDsCODE)
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
See #26332
Changes
Adds a new "Optimize for Experiments" field to data warehouse joins when "events" is selected as the joining table:
The user must also select a source timestamp key:
Data warehouse trends experiment continues to display the expected data:
Clicking "Explore results" generates an insight that renders as expected:
How did you test this code?