Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add criteria to stickiness insight #26410

Merged
merged 28 commits into from
Nov 26, 2024
Merged

feat: Add criteria to stickiness insight #26410

merged 28 commits into from
Nov 26, 2024

Conversation

aspicer
Copy link
Contributor

@aspicer aspicer commented Nov 25, 2024

Problem

We offer the ability to select a stickiness criteria in the cohort builder, but we don't allow it in the stickiness insight
image

Changes

Add the ability to change the stickiness criteria in the insight
image

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Wrote a unit test, tried it out manually

@aspicer aspicer requested a review from a team November 25, 2024 23:01
@aspicer aspicer changed the title [feat] Add criteria to stickiness insight feat: Add criteria to stickiness insight Nov 25, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Size Change: +81 B (+0.01%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +81 B (+0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

20 snapshot changes in total. 0 added, 20 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

20 snapshot changes in total. 0 added, 20 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@aspicer aspicer merged commit 7a347c3 into master Nov 26, 2024
96 checks passed
@aspicer aspicer deleted the aspicer/stickiness branch November 26, 2024 20:42
Copy link

sentry-io bot commented Nov 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ UnboundLocalError: cannot access local variable 'span' where it is not associated with a value posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants