feat: allow hogql property queries in replay filtering #26176

pauldambra · 2024-11-13T18:19:55Z

we don't allow people to add hogql property filters in replay but we could

this PR

allows hogql property queries

## for this PR

convert replay API to not use filters any more behind a flag

to do in follow-up since I want to test the new stuff in prod and everything is behind flags

add a QueryRunner for RecordingsQuery
add autocomplete for replay hogql

hogql filtering

pauldambra · 2024-11-13T18:21:19Z

frontend/src/lib/components/UniversalFilters/universalFiltersLogic.ts

@@ -132,7 +132,7 @@ export const universalFiltersLogic = kea<universalFiltersLogicType>([
                newValues.push(newFeatureFlagFilter)
            } else {
                const propertyType =
-                    item.propertyFilterType ?? taxonomicFilterTypeToPropertyFilterType(taxonomicGroup.type)
+                    item?.propertyFilterType ?? taxonomicFilterTypeToPropertyFilterType(taxonomicGroup.type)


hogql property filters don't have an item so this needs to be slightly safer

pauldambra · 2024-11-13T18:21:37Z

frontend/src/scenes/session-recordings/filters/RecordingsUniversalFilters.tsx

@@ -144,6 +147,7 @@ const RecordingsUniversalFilterGroup = (): JSX.Element => {
                        onRemove={() => removeGroupValue(index)}
                        onChange={(value) => replaceGroupValue(index, value)}
                        initiallyOpen={allowInitiallyOpen}
+                        metadataSource={{ kind: NodeKind.RecordingsQuery }}


we need something here to correct the autocomplete

I need a query runner in python for the recordings query

pauldambra · 2024-11-13T18:21:54Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

@@ -120,6 +120,8 @@ export function convertUniversalFiltersToRecordingsQuery(universalFilters: Recor
            actions.push(f)
        } else if (isLogEntryPropertyFilter(f)) {
            console_log_filters.push(f)
+        } else if (isHogQLPropertyFilter(f)) {


this "just works"™

Does this work for all property types e.g person & event properties? Wondering if the subqueries in the runner affect things here in any way

it works for hogql... am going to ignore everything else for now 🤣
(but noted)

I would be more worried about it not working for folks without PoE enabled (but maybe that's everyone now)

posthog-bot · 2024-11-21T07:32:08Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

…y-filtering

github-actions · 2024-11-23T08:49:25Z

Size Change: +110 B (+0.01%)

Total Size: 1.11 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.11 MB	+110 B (+0.01%)

_{compressed-size-action}

pauldambra · 2024-11-24T10:22:46Z

posthog/session_recordings/session_recording_api.py

-        filter = SessionRecordingsFilter(request=request, team=self.team)
-        self._maybe_report_recording_list_filters_changed(request, team=self.team)
-        return list_recordings_response(filter, request, self.get_serializer_context())
+        use_query_type = (request.GET.get("as_query", "False")).lower() == "true"


let's the API client declare which processing version it accepts so we can test the new mechanism with a slow rollout

posthog-bot · 2024-11-24T10:56:19Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

daibhin

The test files are a little difficult to review but I'll trust that you've just copied them over and not made any implementational changes.

Left a couple of comments but overall the code / approach looks good. Happy enough that it's behind a FF so I'm sure you'll test it for data accuracy :)

daibhin · 2024-12-02T18:19:08Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

+        listAPIAsQuery: [
+            (s) => [s.featureFlags],
+            (featureFlags) => {
+                return !!featureFlags[FEATURE_FLAGS.REPLAY_LIST_RECORDINGS_AS_QUERY]


One thing that always catches me about the query endpoint is the caching. You might need to disable it so that the list refreshes (or maybe the caching is desirable)

yep, i'm slightly wary of moving to the query endpoint tbh 🙈
(just from a "i don't know how this works right now" viewpoint

daibhin · 2024-12-02T18:20:16Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

@@ -120,6 +120,8 @@ export function convertUniversalFiltersToRecordingsQuery(universalFilters: Recor
            actions.push(f)
        } else if (isLogEntryPropertyFilter(f)) {
            console_log_filters.push(f)
+        } else if (isHogQLPropertyFilter(f)) {


Does this work for all property types e.g person & event properties? Wondering if the subqueries in the runner affect things here in any way

daibhin · 2024-12-02T18:21:21Z

frontend/src/queries/schema.ts

    operand?: FilterLogicalOperator
    session_ids?: string[]
    person_uuid?: string
+    /**
+     * @default "start_time"
+     * */


daibhin · 2024-12-02T18:25:02Z

ee/session_recordings/session_recording_playlist.py

+            query = RecordingsQuery.model_validate(data_dict)
+            query.session_ids = playlist_items


Are we only doing this validation because it doesn't go through the /query endpoint? Maybe we should just move it to a runner instead. Totally happy if that's the next step in a followup PR

am going to create a runner so i get autocomplete for the hogql property box
but want to understand that way more before I move this API over 😨

…y-filtering

posthog-bot · 2024-12-03T14:49:51Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-12-03T15:10:39Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

feat: allow hogql property queries in replay filtering

f1d1551

pauldambra commented Nov 13, 2024

View reviewed changes

Schema change so that recordingsquery can be consider

416c61b

posthog-bot added the stale label Nov 21, 2024

Merge branch 'master' into feat/allow-hogql-property-queries-in-repla…

055f2c3

…y-filtering

pauldambra added 2 commits November 23, 2024 09:04

flag the new filter types

d3d8c2f

add failing test

7b35837

pauldambra mentioned this pull request Nov 23, 2024

feat: allow flag queries in replay filtering #26365

Closed

first pass removing flag filtering

b630acd

pauldambra marked this pull request as ready for review November 23, 2024 11:05

pauldambra and others added 9 commits November 23, 2024 11:20

flag the new query route

3b82878

more

9f5b54c

like this?

647faa9

Discard changes to posthog/hogql/printer.py

1454b13

ee tests

00794a3

a little more

438c075

a little more

29de030

almost

54a0650

Update query snapshots

57b6cda

pauldambra commented Nov 24, 2024

View reviewed changes

pauldambra requested a review from a team November 24, 2024 10:23

test should not be passing

1a77a19

pauldambra removed the stale label Nov 24, 2024

Update UI snapshots for chromium (2)

efcfad2

fiddling

62f2a63

daibhin approved these changes Dec 2, 2024

View reviewed changes

pauldambra and others added 21 commits December 2, 2024 18:42

Merge branch 'master' into feat/allow-hogql-property-queries-in-repla…

d249602

…y-filtering

fix

ff64984

Update query snapshots

54cc559

obey mypy

bdc85dc

obey mypy

143dc6b

obeymypy

1f35120

obeymypy

f892a49

obeymypy

7b12a52

obeymypy

2b6a2c2

Update query snapshots

6d9eae2

obeymypy

e809757

obeymypy

0653b9f

obeymypy

d8db5df

schema

d48679b

mypy

e478f7a

obeymypy

e26c8be

Merge branch 'master' into feat/allow-hogql-property-queries-in-repla…

763f7e5

…y-filtering

Discard changes to mypy-baseline.txt

3a75e57

Update query snapshots

3b6c293

rage

07d4ac7

Update UI snapshots for chromium (2)

9db36ed

Update UI snapshots for chromium (2)

48788e3

pauldambra and others added 3 commits December 3, 2024 19:43

fix

9e45158

Update query snapshots

ee74de6

fix

32f0ef1

pauldambra merged commit 7da1bd1 into master Dec 4, 2024
96 checks passed

pauldambra deleted the feat/allow-hogql-property-queries-in-replay-filtering branch December 4, 2024 04:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow hogql property queries in replay filtering #26176

feat: allow hogql property queries in replay filtering #26176

pauldambra commented Nov 13, 2024 •

edited

Loading

pauldambra Nov 13, 2024

pauldambra Nov 13, 2024

pauldambra Nov 13, 2024

pauldambra Nov 13, 2024

daibhin Dec 2, 2024

pauldambra Dec 2, 2024

daibhin Dec 2, 2024

posthog-bot commented Nov 21, 2024

github-actions bot commented Nov 23, 2024 •

edited

Loading

pauldambra Nov 24, 2024

posthog-bot commented Nov 24, 2024

daibhin left a comment

daibhin Dec 2, 2024

pauldambra Dec 2, 2024

daibhin Dec 2, 2024

daibhin Dec 2, 2024

daibhin Dec 2, 2024

pauldambra Dec 2, 2024

posthog-bot commented Dec 3, 2024

posthog-bot commented Dec 3, 2024

		query = RecordingsQuery.model_validate(data_dict)
		query.session_ids = playlist_items

feat: allow hogql property queries in replay filtering #26176

feat: allow hogql property queries in replay filtering #26176

Conversation

pauldambra commented Nov 13, 2024 • edited Loading

hogql filtering

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

posthog-bot commented Nov 21, 2024

github-actions bot commented Nov 23, 2024 • edited Loading

Choose a reason for hiding this comment

posthog-bot commented Nov 24, 2024

📸 UI snapshots have been updated

daibhin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

posthog-bot commented Dec 3, 2024

📸 UI snapshots have been updated

posthog-bot commented Dec 3, 2024

📸 UI snapshots have been updated

pauldambra commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading