Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdp): add snapchat ads destination #26173

Closed
wants to merge 11 commits into from
Closed

feat(cdp): add snapchat ads destination #26173

wants to merge 11 commits into from

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Nov 13, 2024 •
edited
Loading

Changes

  • adds snapchat ads template

Does this work well for both Cloud and self-hosted?

How did you test this code?

added tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@MarconLP MarconLP changed the title add snapchat ads destination feat(cdp): add snapchat ads destination Nov 13, 2024
@MarconLP MarconLP requested a review from a team November 14, 2024 09:37
@MarconLP MarconLP marked this pull request as ready for review November 14, 2024 09:45
benjackwhite
benjackwhite requested changes Nov 14, 2024
View reviewed changes
posthog/cdp/templates/snapchat_ads/template_snapchat_ads.py Outdated Show resolved Hide resolved
posthog/cdp/templates/snapchat_ads/template_snapchat_ads.py Outdated Show resolved Hide resolved
posthog/cdp/templates/snapchat_ads/template_snapchat_ads.py
"key": "accessToken",
"type": "string",
"label": "Access token",
"description": "Check out this page on how to obtain such a token: https://developers.snap.com/api/marketing-api/Conversions-API/GetStarted#access-token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not use the oauth integration? Feels way nicer https://developers.snap.com/snap-kit/login-kit/Tutorials/web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer, but it would require two separate oauth apps since each only supports a single redirect URL. Doesn't seem to be worth the effort as the token is pretty easy to generate, but can look into it if you think it's worth it.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@MarconLP MarconLP removed the stale label Nov 26, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@MarconLP MarconLP removed the stale label Dec 4, 2024
@mariusandra mariusandra mentioned this pull request Dec 13, 2024
Open
@MarconLP MarconLP closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarconLP @posthog-bot @benjackwhite