chore(environments): Backfill project ID on group types #25980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
requested review from
aspicer and
a team
and removed request for
aspicer
Twixes
force-pushed
the
group-type-project-backfill
branch
from
13aced8 to
c4e80d3
Compare
Twixes
force-pushed
the
group-type-project-backfill
branch
from
c4e80d3 to
dcdad27
Compare
aspicer
approved these changes
Nov 6, 2024
benjackwhite
added a commit
that referenced
this pull request
Nov 6, 2024
…)" This reverts commit 8a356a5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continued step 6 of the environments implementation plan.
#25600 added the
GroupTypeMapping.projectfield, but existing group types still have a null value there.Changes
This sets
projecton everyposthog_grouptypemappingrecord, and then makes the field non-nullable in two stages.Stage 1 – this PR:
NOT NULLconstraint is created withNOT VALIDso that the table is not locked.Stage 2 – follow-up PR #25876: We
VALIDATEthe constraint to enforce it in a non-locking way.The two stages must be in separate migrations to actually avoid locking.