Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product-assistant): use header to disable nginx buffering #25907

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Oct 30, 2024

Problem

Streaming doesn't work on production because something buffers the response.

Changes

Set the header that should turn off buffering on nginx for the chat endpoint.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Manul testing

@skoob13 skoob13 requested a review from Twixes October 30, 2024 16:47
@skoob13 skoob13 enabled auto-merge (squash) October 30, 2024 17:01
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds legit

@skoob13 skoob13 merged commit 68ddb00 into master Oct 30, 2024
90 checks passed
@skoob13 skoob13 deleted the fix/disable-buffering-using-headers branch October 30, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants