fix: Only load billing if logged in

[benjackwhite]

Problem

Noticed this whilst trying to debug impersonation issues on EU.

Changes

We don't wan to hit these endpoints unless we are logged in. Given the billingLogic is referenced a lot it ends up being part of the overall base sceneLogic which is always mounted, hence the issue

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

[github-actions]

Size Change: 0 B

Total Size: 1.15 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.15 MB

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

40 snapshot changes in total. 0 added, 40 modified, 0 deleted:

• chromium: 0 added, 40 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[zlwaterfield]

We should look into why all these snapshots changed before merging.

[benjackwhite]

We should look into why all these snapshots changed before merging.

yeah I assume there is no preloaded user in the storybook context... annoying. I'll fix up before merge (unless it indicates a different issue)

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

• chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

[posthog-bot]

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

[zlwaterfield]

Looking at this now.

[posthog-bot]

📸 UI snapshots have been updated

22 snapshot changes in total. 0 added, 22 modified, 0 deleted:

• chromium: 0 added, 22 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[zlwaterfield]

I found the issue but haven't found a solution.

When billingLogic is mounted there is no user but the use is available before the loadBilling call is made so it's available for the call but not for the check. Need to look again at this next week.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

[posthog-bot]

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.