fix: session when impersonated #25897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Oct 30, 2024
| } | ||
|
|
||
| if (window.IMPERSONATED_SESSION) { | ||
| posthog.opt_out_capturing() | ||
| loadedInstance.sessionManager?.resetSessionId() |
There was a problem hiding this comment.
added this to (hopefully) ensure impersonation is always a new session
i'm slightly worried still about a race between start-up continuing a recording and the loaded callback, but this is the lightest touch I can see to try and fix
pauldambra
commented
Oct 30, 2024
Comment on lines
+44
to
+63
| const Cypress = (window as any).Cypress | ||
|
|
||
| if (Cypress) { | ||
| Object.entries(Cypress.env()).forEach(([key, value]) => { | ||
| if (key.startsWith('POSTHOG_PROPERTY_')) { | ||
| loadedInstance.register_for_session({ | ||
| [key.replace('POSTHOG_PROPERTY_', 'E2E_TESTING_').toLowerCase()]: value, | ||
| }) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| // This is a helpful flag to set to automatically reset the recording session on load for testing multiple recordings | ||
| const shouldResetSessionOnLoad = loadedInstance.getFeatureFlag(FEATURE_FLAGS.SESSION_RESET_ON_LOAD) | ||
| if (shouldResetSessionOnLoad) { | ||
| loadedInstance.sessionManager?.resetSessionId() | ||
| } | ||
|
|
||
| // Make sure we have access to the object in window for debugging | ||
| window.posthog = loadedInstance |
There was a problem hiding this comment.
moved these into the loaded callback to make it a little clearer what we think we're operating on
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
oliverb123
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session replay takes any distinct id from a session
we've noticed a couple of times that when posthog staff impersonate a user sometimes that session ends up having the impersonated user's distinct id in the replay events table
and if you then search for posthog staff we'll display the, legitimately by a posthog-person, session as if its user was the impersonated user
the persons in posthog aren't being merged, we're just managing to write a "bad" distinct id into replay events
i don't think i can do impersonation locally, and it's not happening every time, so it's difficult to reproduce but...
let's reset the session id when we impersonate a user to try and avoid this (I guess) little race